[Editor] Tweak the save flow in the alt-text dialog #17005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/aabd330c911da52/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/aabd330c911da52/output.txt Total script time: 1.47 mins Published |
|
It doesn't seem that the tooltip is being restored correctly now:
|
marco-c
changed the title
calixteman
force-pushed
the
alt_text_tweak_save_flow
branch
2 times, most recently
from
ca95bf9
to
3b58a69
Compare
When the user edit an existing alt-text and remove it, we want to be able to save this state and consequently remove the done state from the alt-text button. Remove the button from its parent when the editor is removed: it should help to save few Kb of memory.
calixteman
force-pushed
the
alt_text_tweak_save_flow
branch
from
3b58a69
to
050093c
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8b2a18c23ada464/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8b2a18c23ada464/output.txt Total script time: 1.52 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user edit an existing alt-text and remove it, we want to be able to save this state and consequently remove the done state from the alt-text button.
Remove the button from its parent when the editor is removed: it should help to save few Kb of memory.