Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "GoToE" actions with destinations (issue 17056) #17060

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add support for "GoToE" actions with destinations (issue 17056) #17060

merged 1 commit into from
Oct 4, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This shouldn't be very common in practice, since "GoToE" actions themselves seem quite uncommon; see PR #15537.

@Snuffleupagus Snuffleupagus linked an issue Oct 3, 2023 that may be closed by this pull request
/GoToE links only go to embedded file, not to destination #17056
Closed
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@Snuffleupagus Snuffleupagus force-pushed the issue-17056 branch 2 times, most recently from e3820c8 to 320f168 Compare October 3, 2023 07:21
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 3, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 4, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 4, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 4, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 4, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e4ec501f4b83b33/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7cbbd326104f2c2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e4ec501f4b83b33/output.txt

Total script time: 2.61 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7cbbd326104f2c2/output.txt

Total script time: 13.64 mins

  • Unit Tests: Passed

calixteman
calixteman reviewed Oct 4, 2023
View reviewed changes
src/core/catalog.js Outdated Show resolved Hide resolved
calixteman
calixteman approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Add support for "GoToE" actions with destinations (issue 17056)
bf9c33e 
This shouldn't be very common in practice, since "GoToE" actions themselves seem quite uncommon; see PR 15537.
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9b257d66c5eff3b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/00a87a82ca1dfa7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/00a87a82ca1dfa7/output.txt

Total script time: 2.56 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9b257d66c5eff3b/output.txt

Total script time: 14.20 mins

  • Unit Tests: Passed

@Snuffleupagus Snuffleupagus merged commit c377f2d into mozilla:master Oct 4, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17056 branch October 4, 2023 09:36
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/GoToE links only go to embedded file, not to destination
3 participants
@Snuffleupagus @moz-tools-bot @calixteman