Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the noHTML flag to take into account the hasOwnCanvas one (fixes #17069) #17070

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Update the noHTML flag to take into account the hasOwnCanvas one (fixes #17069) #17070

merged 1 commit into from
Oct 5, 2023

Conversation

calixteman
Copy link
Contributor

When an element has the hasOwnCanvas flag we must have an HTML container to attach the canvas where the element will be rendered.
So the noHTML flag must take this information into account:

  • in some cases the noHTML flag is resetted depending on the hasOwnCanvas value;
  • in some others, the hasOwnCanvas flag is set depending on the value of noHTML.

@calixteman calixteman linked an issue Oct 4, 2023 that may be closed by this pull request
Elements not displayed in demo viewer #17069
Closed
@Snuffleupagus
Copy link
Collaborator

Let's ensure that this passes all tests before I attempt to review this.

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dc5a4b19f70b96d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/879f89e1b8f4c6a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dc5a4b19f70b96d/output.txt

Total script time: 29.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 49
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/dc5a4b19f70b96d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/879f89e1b8f4c6a/output.txt

Total script time: 38.74 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 42

Image differences available at: http://54.193.163.58:8877/879f89e1b8f4c6a/reftest-analyzer.html#web=eq.log

@calixteman
Update the noHTML flag to take into account the hasOwnCanvas one (fixes
40b1d92 
mozilla#17069)

When an element has the hasOwnCanvas flag we must have an HTML container to attach
the canvas where the element will be rendered.
So the noHTML flag must take this information into account:
 - in some cases the noHTML flag is resetted depending on the hasOwnCanvas value;
 - in some others, the hasOwnCanvas flag is set depending on the value of noHTML.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4b8b465ab1e3477/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1281e17d4da5a71/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1281e17d4da5a71/output.txt

Total script time: 27.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/1281e17d4da5a71/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4b8b465ab1e3477/output.txt

Total script time: 37.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 31
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/4b8b465ab1e3477/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that we've not missed any cases, but this seems to make sense.

r=me, thank you!

@calixteman calixteman merged commit c4c24c6 into mozilla:master Oct 5, 2023
3 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/48196ed8108ea2d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c8fd21ddbbdb26b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c8fd21ddbbdb26b/output.txt

Total script time: 21.21 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/48196ed8108ea2d/output.txt

Total script time: 24.59 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

calixteman added a commit to calixteman/pdf.js that referenced this pull request Oct 5, 2023
@calixteman
Add a HTML containter for locked FreeText annotations in order to be …
e737638 
…able to display a popup (follow-up iof mozilla#17070)
calixteman added a commit that referenced this pull request Oct 5, 2023
@calixteman
Merge pull request #17075 from calixteman/issue17069_followup
a60f90a 
Add a HTML containter for locked FreeText annotations in order to be able to display a popup (follow-up of #17070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elements not displayed in demo viewer
3 participants
@calixteman @Snuffleupagus @moz-tools-bot