Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store page-level data, in the API, after cleanup has run (bug 1854145) #17106

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Don't store page-level data, in the API, after cleanup has run (bug 1854145) #17106

merged 1 commit into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. Don't store page-level data, in the API, after cleanup has run (bug 1… 

    …854145)

For large/complex images it's possible that the image-data arrives in the API *after* the page has been scrolled out-of-view and thus been cleaned-up. In this case we obviously shouldn't cache such page-level data, since it'll first of all be unused and secondly can increase memory usage *a lot*.
Also, ensure that we *immediately* release any `ImageBitmap` data in this case to help reclaim memory faster.
    @Snuffleupagus
    Snuffleupagus committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0238cf1 View commit details
    Browse the repository at this point in the history