Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the L10n-instance as soon as possible in Firefox (PR 17115 follow-up) #17140

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Initialize the L10n-instance as soon as possible in Firefox (PR 17115 follow-up) #17140

merged 1 commit into from
Oct 19, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Given that there's now a bit more asynchronicity in the l10n-initialization in the Firefox PDF Viewer, after PR #17115, try to limit the impact of that by moving it to occur a tiny bit earlier in the default viewer initialization.

@Snuffleupagus
Initialize the L10n-instance as soon as possible in Firefox (PR 171…
5c14c55 
…15 follow-up)

Given that there's now a bit more asynchronicity in the l10n-initialization in the Firefox PDF Viewer, after PR 17115, try to limit the impact of that by moving it to occur a tiny bit earlier in the default viewer initialization.
@mozilla mozilla deleted a comment from moz-tools-bot Oct 19, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Oct 19, 2023
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9030e925ee65470/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9030e925ee65470/output.txt

Total script time: 1.45 mins

Published

calixteman
calixteman approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman added the l10n Localization label Oct 19, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f9a2b5d0f233598/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6b5972b5070c87b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f9a2b5d0f233598/output.txt

Total script time: 10.52 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/f9a2b5d0f233598/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6b5972b5070c87b/output.txt

Total script time: 19.74 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/6b5972b5070c87b/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 5f0e560 into mozilla:master Oct 19, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the l10n-move-init branch October 19, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
l10n Localization viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman