Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L10n] Don't try to connect the root element when it has already been done #17142

Merged
merged 1 commit into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. [L10n] Don't try to connect the root element when it has already been…

    … done
    
    In Firefox debug builds, there is an assertion to check that we don't connect
    a subelement of an already connected root. Thanks to this assertion, we can see
    that the root has already been added to Fluent, hence we don't need to do it
    a second time.
    We don't need to await anymore on the translation in order to update the
    toolbar: it'll be done by Fluent, so we can safely remove the "localized"
    event and avoid to wait for it.
    calixteman committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    a0b9c93 View commit details
    Browse the repository at this point in the history