[Editor] Don't steal the keyboard events when editing mode is enabled

[calixteman]

No description provided.

[Snuffleupagus]

I'm sorry to say that I'm not a fan of having to sprinkle event-handlers throughout the viewer code-base, since it really doesn't feel like a very maintainable solution.

Can't we handle this at the Editor-level instead, e.g. by checking that the active element is within the page and/or viewer?

[calixteman]

I'm sorry to say that I'm not a fan of having to sprinkle event-handlers throughout the viewer code-base, since it really doesn't feel like a very maintainable solution.

Can't we handle this at the Editor-level instead, e.g. by checking that the active element is within the page and/or viewer?

To be honest, my feeling is that nothing is exciting here. If in 6 months we've to add an element in the UI which can be controlled with the keyboard, we've to remember that it can badly interact with the editing mode, even if it's unrelated.
In an ideal world, events should have a flag which would be true when they've been consumed during the bubbling phase...
That said, it isn't that simple: for example if you click on a slider on then press ctrl+Z, the active element is the slider but.
So we've to take of the type of the active element and when it's an input we've to take care of the type of input (a slider isn't the same as a text input) so it leads to more complexity.
That said, your inline comment is the best argument to say that this patch is not doing the right thing: I'll fix that.

[Snuffleupagus]

r=me, thank you!

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cfb72308491df92/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/019660720d9d4e9/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/019660720d9d4e9/output.txt

Total script time: 5.68 mins

• Integration Tests: FAILED

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/cfb72308491df92/output.txt

Total script time: 19.20 mins

• Integration Tests: Passed

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e05bf72a7deded8/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8e27b554b171c5e/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/e05bf72a7deded8/output.txt

Total script time: 2.36 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/8e27b554b171c5e/output.txt

Total script time: 8.57 mins

• Integration Tests: Passed

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/06fa5fecd7669cd/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f48a64df1c9b38a/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/06fa5fecd7669cd/output.txt

Total script time: 5.49 mins

• Integration Tests: FAILED

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/f48a64df1c9b38a/output.txt

Total script time: 14.97 mins

• Integration Tests: Passed