Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENERIC viewer] Fallback to the short-format of the language code (issue 17269) #17270

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This shouldn't cause any issues, since GenericL10n.#createBundle has an early return for languages that don't exist in the locale.json file.

…ssue 17269)

This shouldn't cause any issues, since `GenericL10n.#createBundle` has an early return for languages that don't exist in the `locale.json` file.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c8dc2a4b24b83b8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/c8dc2a4b24b83b8/output.txt

Total script time: 1.40 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 7b89e7e into mozilla:master Nov 13, 2023
7 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17269 branch November 13, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n Localization viewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 4.0 locale doesn't recognize xx-XX format from navigator.language and defaults to en-US
3 participants