Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the option to set light/dark mode for chromium and generic builds #17293

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Restore the option to set light/dark mode for chromium and generic builds #17293

merged 1 commit into from
Nov 18, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Nov 18, 2023 that may be closed by this pull request
Restore the dark mode for the chrome plugin #17227
Closed
Snuffleupagus
Snuffleupagus requested changes Nov 18, 2023
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
web/app_options.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

web/app.js Outdated Show resolved Hide resolved
@calixteman calixteman merged commit 3459615 into mozilla:master Nov 18, 2023
9 checks passed
@Rob--W Rob--W mentioned this pull request Nov 18, 2023
Merged
@calixteman calixteman mentioned this pull request Dec 5, 2023
Closed
@hecerinc
Copy link

@calixteman it looks like this was only reenabled for Chromium browsers? Is there any way this could be honored for FF prefs as well?

@calixteman
Copy link
Contributor Author

@calixteman it looks like this was only reenabled for Chromium browsers? Is there any way this could be honored for FF prefs as well?

The theme for the pdf viewer is the same as the Firefox one, hence you can just switch the theme in the settings (Hamburger menu > Settings > Language and Appearance):
image

@hecerinc
Copy link

Sure, but I would like to keep my general browsing in light mode, while viewing PDFs in dark mode, which this setting previously allowed me to do

@hecerinc
Copy link

hecerinc commented Feb 4, 2024

@calixteman any updates on this?

@calixteman
Copy link
Contributor Author

It has been restored a while back, please read #14059.

@hecerinc
Copy link

hecerinc commented Feb 5, 2024

AFAICT this option was only restored for Chromium builds, is that right? I'm asking for the option to be reenabled for Firefox as well

@hecerinc
Copy link

@calixteman is this feasible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
chrome-specific viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore the dark mode for the chrome plugin
4 participants
@calixteman @hecerinc @Snuffleupagus @timvandermeij