Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add a new editor to highlight some text in a pdf (bug 1866119) #17317

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[Editor] Add a new editor to highlight some text in a pdf (bug 1866119) #17317

merged 1 commit into from
Nov 28, 2023

Conversation

calixteman
Copy link
Contributor

This patch is first big step for the new highlight feature.
Few patches will follow in order to conform to the specs UX/UI gave us.

@mozilla mozilla deleted a comment from moz-tools-bot Nov 22, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Nov 22, 2023
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f5c262585388d4a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f5c262585388d4a/output.txt

Total script time: 1.44 mins

Published

Snuffleupagus
Snuffleupagus reviewed Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a couple of comments on the web/-parts, since I've not had time to look at the src/display/editor/ changes yet.

web/annotation_editor_layer_builder.css Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
web/viewer.html Outdated Show resolved Hide resolved
web/viewer.html Show resolved Hide resolved
web/app.js Show resolved Hide resolved
src/display/editor/toolbar.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus reviewed Nov 27, 2023
View reviewed changes
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_page_view.js Outdated Show resolved Hide resolved
web/pdf_viewer.css Outdated Show resolved Hide resolved
src/display/editor/highlight.js Show resolved Hide resolved
src/display/editor/highlight.js Show resolved Hide resolved
src/display/editor/highlight.js Outdated Show resolved Hide resolved
src/display/editor/highlight.js Show resolved Hide resolved
src/display/editor/highlight.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the editor_highlight branch 2 times, most recently from 349e3f2 to e3a1153 Compare November 27, 2023 16:17
Snuffleupagus
Snuffleupagus approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fair bit of code, so hopefully I've not missed anything "important", but overall this seems reasonable.
Please make sure that you run all tests before landing this.

r=me, thank you!

src/display/editor/annotation_editor_layer.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
@calixteman
[Editor] Add a new editor to highlight some text in a pdf (bug 1866119)
1ea6293 
This patch is first big step for the new highlight feature.
Few patches will follow in order to conform to the specs UX/UI gave us.
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b4b3008ac1ed91a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c91fa7eb0dbc9f7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b4b3008ac1ed91a/output.txt

Total script time: 23.91 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b4b3008ac1ed91a/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c91fa7eb0dbc9f7/output.txt

Total script time: 34.11 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 24

Image differences available at: http://54.193.163.58:8877/c91fa7eb0dbc9f7/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 8e2507e into mozilla:master Nov 28, 2023
9 checks passed
@calixteman calixteman deleted the editor_highlight branch November 28, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus