-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and translations to the most recent versions #17334
Conversation
This patch is automatically generated using `gulp lint --fix`.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/30012b418c0a82f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/30012b418c0a82f/output.txt Total script time: 1.38 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/70bd46f906c3455/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a42bed72ee4dcae/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/70bd46f906c3455/output.txt Total script time: 26.08 mins
Image differences available at: http://54.241.84.105:8877/70bd46f906c3455/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a42bed72ee4dcae/output.txt Total script time: 35.46 mins
Image differences available at: http://54.193.163.58:8877/a42bed72ee4dcae/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
This commit fixes the JSDoc comment for the `annotationEditorMode` setter. The types tests fail on that now because the input value was changed from a number to an object with various properties in recent patches, but the JSDoc comment was not updated accordingly. Moreover, the types tests also fail because TypeScript 5.3 assumes that getters and setters have equal return and input value types, which is arguably also what one would expect, but our `annotationEditorMode` getter and setter deviate from that because the getter returns a number while the setter accepts an object. Given that it seems more important to document the setter entirely, including the meaning and types of its properties, and the type of the getter can easily be inferred from this comment and the other JSDoc comments that have `annotationEditorMode` in it, we remove the getter type to make the types tests pass again.
0c5b43f
to
ab692f8
Compare
The commit messages contain more details about the individual changes.