-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Avoid to add a new ink editor when we aren't editing anymore #17344
Conversation
Is this a (recent) regression, or has this always been broken without anyone noticing until now? |
1d5fc57
to
2be136a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Seeing the initial patch I was about to ask about the early return in addInkEditorIfNeeded
, but the updated patch already addressed that :-)
r=me, thank you!
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6520a8145c7d8a1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a53a5824071332e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a53a5824071332e/output.txt Total script time: 5.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/6520a8145c7d8a1/output.txt Total script time: 16.51 mins
|
No description provided.