Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Avoid to add a new ink editor when we aren't editing anymore #17344

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Nov 27, 2023 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator

Is this a (recent) regression, or has this always been broken without anyone noticing until now?

@calixteman
Copy link
Contributor Author

I was ready to write "It's has always been broken"... but in checking in a one-year old Firefox, I wasn't able to reproduce and neither in nightly...
Finally it's a very recent "regression" from: #17330
I quoted regression because, I think the bug I fixed in #17330 was hiding this issue.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Seeing the initial patch I was about to ask about the early return in addInkEditorIfNeeded, but the updated patch already addressed that :-)

r=me, thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6520a8145c7d8a1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a53a5824071332e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a53a5824071332e/output.txt

Total script time: 5.54 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/6520a8145c7d8a1/output.txt

Total script time: 16.51 mins

  • Integration Tests: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when leaving Annotation Mode
3 participants