Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Fix the colors in HCM when hovering a button in the editor toolbar #17352

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

calixteman
Copy link
Contributor

It fixes few errors in the CSS for HCM.
It now complies to the specs from UI/UX.
Only the foreground must change in HCM and not the background, similarly to what we had for the alt-text button before moving it.

@Snuffleupagus
Copy link
Collaborator

Is there actually supposed to be both an outline and a darker background-color on hover in normal (i.e. non-HCM) mode now, since that seems a bit redundant?

…oolbar

It fixes few errors in the CSS for HCM.
It now complies to the specs from UI/UX.
Only the foreground must change in HCM and not the background, similarly to what
we had for the alt-text button before moving it.
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a973ad3eb0ce72e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a973ad3eb0ce72e/output.txt

Total script time: 1.56 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

@calixteman calixteman merged commit 9ac1ac6 into mozilla:master Nov 29, 2023
7 checks passed
@calixteman calixteman deleted the move_button_hcm branch November 29, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants