Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "transitionend" event listener from the default viewer (issue 17347) #17360

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Given that this event listener is only used to trigger rendering after the sidebar has been opened/closed, we can utilize the existing one in the PDFSidebar class for this purpose instead. That one is registered on the sidebar DOM-element, and is needed to remove a CSS-class indicating that the sidebar is moving.

…sue 17347)

Given that this event listener is only used to trigger rendering after the sidebar has been opened/closed, we can utilize the existing one in the `PDFSidebar` class for this purpose instead. That one is registered on the sidebar DOM-element, and is needed to remove a CSS-class indicating that the sidebar is moving.
@Snuffleupagus
Copy link
Collaborator Author

Note: Removing the "transitionend" event listener from PDFSidebar as well would, most likely, require much larger changes to the CSS and JavaScript code. Hence I'm hoping that this is good enough here :-)

…ode.js versions (PR 17202 follow-up)

It seems this unit-test started failing in Node.js version 20.10 as well. We should probably try and understand why, but for now just disable it to get passing CI tests.
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c8c01faa2bb0b24/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/670f3cec58e0162/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/670f3cec58e0162/output.txt

Total script time: 5.44 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c8c01faa2bb0b24/output.txt

Total script time: 14.41 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus merged commit 096426f into mozilla:master Dec 1, 2023
7 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17347 branch December 1, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate if we can remove "transitionend" event listener
3 participants