-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center radio button checkmark #17429
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d6f80d06f766731/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc1fbe8b6f45800/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/cc1fbe8b6f45800/output.txt Total script time: 23.86 mins
Image differences available at: http://54.241.84.105:8877/cc1fbe8b6f45800/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d6f80d06f766731/output.txt Total script time: 37.14 mins
Image differences available at: http://54.193.163.58:8877/d6f80d06f766731/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that these changes are covered by existing reference-tests, based on the movement in some forms
-tests, we probably don't need to add a new test-case for issue #12238 here.
Based on local testing and squinting at the reference-test images, this seems to be a slight improvement overall and the new left/top-values do seem more logical.
r=me, thank you!
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8b3d93ccfa2405a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ae7de98f0113b17/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ae7de98f0113b17/output.txt Total script time: 18.39 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8b3d93ccfa2405a/output.txt Total script time: 26.27 mins
|
fixes #12238