-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve the whitespaces when getting text from FreeText annotations (bug 1871353) #17458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also run all tests, once the comments have been addressed.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1af66331beec2d4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/0bde8a5af8b4a2b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1af66331beec2d4/output.txt Total script time: 24.36 mins
Image differences available at: http://54.241.84.105:8877/1af66331beec2d4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0bde8a5af8b4a2b/output.txt Total script time: 37.68 mins
Image differences available at: http://54.193.163.58:8877/0bde8a5af8b4a2b/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/389a14a5c75c3fc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1a790a93864595e/output.txt |
…(bug 1871353) When the text of an annotation is extracted in using getTextContent, consecutive white spaces are just replaced by one space and. So this patch add an option to make sure that white spaces are preserved when appearance is parsed. For the case where there's no appearance, we can have a fast path to get the correct string from the Content entry. When an existing FreeText is edited, space (0x20) are replaced by non-breakable (0xa0) ones to make to see all of them on screen.
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1a790a93864595e/output.txt Total script time: 24.40 mins
Image differences available at: http://54.241.84.105:8877/1a790a93864595e/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/389a14a5c75c3fc/output.txt Total script time: 40.07 mins
Image differences available at: http://54.193.163.58:8877/389a14a5c75c3fc/reftest-analyzer.html#web=eq.log |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d66db2e48dc4cf6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4f097f4efcd3f7e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d66db2e48dc4cf6/output.txt Total script time: 5.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4f097f4efcd3f7e/output.txt Total script time: 18.71 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
When the text of an annotation is extracted in using getTextContent, consecutive white spaces are just replaced by one space and. So this patch add an option to make sure that white spaces are preserved when appearance is parsed.
For the case where there's no appearance, we can have a fast path to get the correct string from the Content entry.
When an existing FreeText is edited, space (0x20) are replaced by non-breakable (0xa0) ones to make to see all of them on screen.