Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add support for printing/saving free highlight annotations #17531

Merged
merged 1 commit into from
Jan 19, 2024
Merged

[Editor] Add support for printing/saving free highlight annotations #17531

merged 1 commit into from
Jan 19, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman force-pushed the editor_free_highlight_print_save branch from c29ffd3 to 9709db9 Compare January 18, 2024 17:07
Snuffleupagus
Snuffleupagus requested changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When saving a PDF document with a free-highlight, does the generated PDF hit this work-around once opened with PDF.js?
Because if so we may need to fix that properly now, since otherwise we'd be ignoring the appearance-stream that we previously generated.

src/core/annotation.js Outdated Show resolved Hide resolved
src/core/writer.js Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

When saving a PDF document with a free-highlight, does the generated PDF hit this work-around once opened with PDF.js? Because if so we may need to fix that properly now, since otherwise we'd be ignoring the appearance-stream that we previously generated.

The free-highlight is a Ink annotation so the workaround doesn't apply here.

@calixteman calixteman force-pushed the editor_free_highlight_print_save branch from 9709db9 to d64f334 Compare January 19, 2024 11:58
Snuffleupagus
Snuffleupagus approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4028db3d7959231/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/03734e39cf9c729/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4028db3d7959231/output.txt

Total script time: 24.52 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/4028db3d7959231/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/03734e39cf9c729/output.txt

Total script time: 38.33 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 20
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/03734e39cf9c729/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit f6c4b29 into mozilla:master Jan 19, 2024
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3b78dd59e945dba/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e19cacfa2fb7f43/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e19cacfa2fb7f43/output.txt

Total script time: 18.40 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/3b78dd59e945dba/output.txt

Total script time: 26.20 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus