Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Don't add the keyboard listener on the color-picker each time the dropdown menu is shown #17539

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

calixteman
Copy link
Contributor

and display/hide the dropdown menu when pressing arrow keys.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a few suggestions; thank you!

src/display/editor/color_picker.js Outdated Show resolved Hide resolved
src/display/editor/color_picker.js Outdated Show resolved Hide resolved
…e the dropdown menu is shown

and display/hide the dropdown menu when pressing arrow keys.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1fa7afdc1d1830c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bce87c860faad01/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/bce87c860faad01/output.txt

Total script time: 6.18 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/1fa7afdc1d1830c/output.txt

Total script time: 14.03 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 6e46304 into mozilla:master Jan 20, 2024
9 checks passed
@calixteman calixteman deleted the color_picker_kb branch January 20, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants