Commits on Jan 21, 2024

1. Don't ignore test.mjs child process exit codes in the Gulpfile …

   In the Gulpfile only the exit codes of `test.mjs` child processes
   erroneously aren't checked. This causes failures in `test.mjs` to be
   logged but not propagated to the master process, which in turn causes
   test runners such as GitHub Actions to succeed because they only
   monitor the master process. This is easy to reproduce by throwing an
   error at the top of `test.mjs` and running `gulp makeref` or `gulp
   unittest`: the error is logged, but the task that spawned the child
   process succeeds and the master process exits with exit code 0. This is
   problematic because it can easily cause errors to go by unnoticed.
   
   This commit fixes the issue by making sure that the `test.mjs`
   invocations are handled in the same way as the other child processes
   in the file, i.e., if the child process exits with a non-zero exit code
   then the master process also exits with a non-zero exit code. After this
   patch the error is still logged, but the task now also fails and the
   master process exits with exit code 1 to properly signal failure.

   

   timvandermeij committed Jan 21, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6dd77b3
   • Browse repository at this point

   Copy the full SHA

   6dd77b3 View commit details

   Browse the repository at this point in the history