Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting of cursor-tools when closing the document (PR 17464 follow-up) #17933

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

With the removal of the "secondarytoolbarreset" event in PR #17464 resetting of cursor-tools state accidentally broke.

…low-up)

With the removal of the "secondarytoolbarreset" event in PR 17464 resetting of cursor-tools state accidentally broke.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a527ba35399a4b0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a527ba35399a4b0/output.txt

Total script time: 1.24 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I thought I had also searched for remaining usages of the events in the previous PR but apparently also missed this. I did double-check this time that after this no usages remain of both events.

@timvandermeij timvandermeij merged commit e005e6e into mozilla:master Apr 12, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the pr-17464-followup branch April 12, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants