-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JPX] Throw an exception with the error messages returned by openjpeg #17956
Conversation
6cb7653
to
ebcae30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the tests passing. I have checked out this PR locally and confirmed that the fuzzer no longer spams log messages:
$ npx jazzer fuzz/jpx_image.fuzz --sync
Dictionary: 4 entries
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3792403092
INFO: Loaded 1 modules (512 inline 8-bit counters): 512 [0x7e4cbb0ff010, 0x7e4cbb0ff210),
INFO: Loaded 1 PC tables (512 PCs): 512 [0x7e4cb2400010,0x7e4cb2402010),
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
INFO: A corpus is not provided, starting from an empty corpus
#2 INITED exec/s: 0 rss: 137Mb
WARNING: no interesting inputs were found so far. Is the code instrumented for coverage?
This may also happen if the target rejected all inputs we tried so far
#65536 pulse corp: 1/1b lim: 652 exec/s: 21845 rss: 154Mb
#131072 pulse corp: 1/1b lim: 1300 exec/s: 18724 rss: 154Mb
#262144 pulse corp: 1/1b lim: 2611 exec/s: 17476 rss: 154Mb
Thank you for improving this!
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9ebb2bba3dd4c11/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0439252b3a87dcb/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0439252b3a87dcb/output.txt Total script time: 2.62 mins
Image differences available at: http://54.193.163.58:8877/0439252b3a87dcb/reftest-analyzer.html#web=eq.log |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/39661a2c156ea2c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9ebb2bba3dd4c11/output.txt Total script time: 27.01 mins
Image differences available at: http://54.241.84.105:8877/9ebb2bba3dd4c11/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/39661a2c156ea2c/output.txt Total script time: 41.08 mins
Image differences available at: http://54.193.163.58:8877/39661a2c156ea2c/reftest-analyzer.html#web=eq.log |
Fixes #17955.