Extend the globally cached image main-thread copying to "complex" images as well (PR 17428 follow-up) #17978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
pr-17428-followup
branch
3 times, most recently
from
93dfeb1
to
561d8be
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2fcb3633114b7fb/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/78ee4fd93f0bd42/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/78ee4fd93f0bd42/output.txt Total script time: 27.09 mins
Image differences available at: http://54.241.84.105:8877/78ee4fd93f0bd42/reftest-analyzer.html#web=eq.log |
…ges as well (PR 17428 follow-up) In PR 17428 this functionality was limited to "larger" images, to not affect performance negatively. However it turns out that it's also beneficial to consider more "complex" images, regardless of their size, that contain /SMask or /Mask data; see issue 11518.
Snuffleupagus
force-pushed
the
pr-17428-followup
branch
from
561d8be
to
91898e5
Compare
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2fcb3633114b7fb/output.txt Total script time: 40.09 mins
Image differences available at: http://54.193.163.58:8877/2fcb3633114b7fb/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #17428 this functionality was limited to "larger" images, to not affect performance negatively. However it turns out that it's also beneficial to consider more "complex" images, regardless of their size, that contain /SMask or /Mask data; see issue #11518.
Fixes #11518 (to the extent that doing so is possible, since besides improved caching the rest of the "problem" is image-decoder related and that's now handled by the OpenJPEG library).