Improve jpx decoding by around 20% in enabling simd support when compiling OpenJPEG

[calixteman]

No description provided.

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/368b8497d3f05d7/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/78c62b0b48068c7/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/78c62b0b48068c7/output.txt

Total script time: 26.90 mins

• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 18
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/78c62b0b48068c7/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/368b8497d3f05d7/output.txt

Total script time: 39.32 mins

• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/368b8497d3f05d7/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

Have you tested that the image decoder still works in Node.js environments with this change?

[calixteman]

No I didn't.
I just ran: gulp image_decoders.
In node, I ran:

const { JpxImage } = await import("./build/image_decoders/pdf.image_decoders.mjs");
JpxImage.decode(new Uint8Array([0]));

and it complains because of the wrong format but the wasm loaded, so it should be ok.
My node version is 18.19.1.
If there's a risk to break something, shouldn't we have some tests ?

[Snuffleupagus]

If there's a risk to break something, shouldn't we have some tests ?

I just wanted to check that the SIMD-part didn't break anything (we probably don't need specific Node.js tests here).

[Snuffleupagus]

r=me, thank you!