[api-minor] Move the page reference/number caching into the API #18001
Conversation
|
/botio xfatest |
Snuffleupagus
force-pushed
the
api-pageRefCache
branch
from
ea8ffa8 to
58e7225
Compare
Snuffleupagus
force-pushed
the
api-pageRefCache
branch
from
58e7225 to
e5e4890
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/519f5578a5b4b1b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/85762f08932f492/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/519f5578a5b4b1b/output.txt Total script time: 27.12 mins
Image differences available at: http://54.241.84.105:8877/519f5578a5b4b1b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/85762f08932f492/output.txt Total script time: 42.63 mins
Image differences available at: http://54.193.163.58:8877/85762f08932f492/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
api-pageRefCache
branch
2 times, most recently
from
d3984b2 to
e3361a9
Compare
We no longer need the helper method to *potentially* call itself once data is available, and can instead take full advantage of async/await by inlining the code.
Rather than having to handle this *manually* throughout the viewer, this functionality can instead be moved into the API which simplifies the code slightly.
…984 follow-up) After the changes in PR 17984 this code can no longer be reached, since the destination is now validated on the worker-thread.
Snuffleupagus
force-pushed
the
api-pageRefCache
branch
from
e3361a9 to
150964d
Compare
|
Thank you for improving this! To me it also makes more sense to handle this in the API instead of in the viewer. |
Rather than having to handle this manually throughout the viewer, this functionality can instead be moved into the API which simplifies the code slightly.