Remove the limit used to decided if a group canvas must be upscaled or not #18035
Conversation
…r not It fixes issues mozilla#14982 and mozilla#14724. The main problem of upscaling a canvas is that it can induces some pixelation (see issue mozilla#14724). So this patch is just removing the limit and as a side effect it fixes issue mozilla#14982. As far as I can tell, in looking different profiles (especially some memory profile) in using the Firefox profiler, I don't see any noticeable difference in term of memory use.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/3033eee31b6acde/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/98ceda6b092a05c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/98ceda6b092a05c/output.txt Total script time: 27.87 mins
Image differences available at: http://54.241.84.105:8877/98ceda6b092a05c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3033eee31b6acde/output.txt Total script time: 42.83 mins
Image differences available at: http://54.193.163.58:8877/3033eee31b6acde/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3549d29d8550fcd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3549d29d8550fcd/output.txt Total script time: 1.19 mins Published |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/11560abedc4d4cf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/aaf1c458aca799b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/11560abedc4d4cf/output.txt Total script time: 20.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/aaf1c458aca799b/output.txt Total script time: 25.44 mins
|
It fixes issues #14982 and #14724.
The main problem of upscaling a canvas is that it can induces some pixelation (see issue #14724). So this patch is just removing the limit and as a side effect it fixes issue #14982.
As far as I can tell, in looking different profiles (especially some memory profile) in using the Firefox profiler, I don't see any noticeable difference in term of memory use.