Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix rendering problem when zooming on Safari" for causing bug 1895909 #18079

Merged
merged 1 commit into from
May 13, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Reverts #18019

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ee177cb1a62c375/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/ee177cb1a62c375/output.txt

Total script time: 1.15 mins

Published

@timvandermeij timvandermeij merged commit df23679 into master May 13, 2024
13 checks passed
@timvandermeij timvandermeij deleted the revert-18019-safari-zoom-fix branch May 13, 2024 14:45
@timvandermeij
Copy link
Contributor

r=me; as mentioned in the original PR, if there would be a regression we'd revert this.

@calixteman
Copy link
Contributor

From my pov, the real problem isn't the original PR which just revealed an other problem: our CSS isn't perfect.

@timvandermeij
Copy link
Contributor

Yes, but I also agree with @Snuffleupagus that it's best to first get back to the original working state before we do additional work in this area. Now that we know what regressed that gives us time, and a good opportunity, to e.g. introduce more tests and refactor the CSS first to avoid future regressions, which I do think is a really good idea indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants