-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline the _fetchDocument
helper function in getDocument
#18091
Inline the _fetchDocument
helper function in getDocument
#18091
Conversation
This function has been modified a number of times over the years, and at this point it's small/simple enough that we can just inline the code instead.
This is fairly old code, and at some point the need for this to be asynchronous disappeared.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/725a0c44bb138cb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/725a0c44bb138cb/output.txt Total script time: 1.26 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d44e32abd833363/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/256eff0d6d4cb48/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/256eff0d6d4cb48/output.txt Total script time: 27.65 mins
Image differences available at: http://54.241.84.105:8877/256eff0d6d4cb48/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d44e32abd833363/output.txt Total script time: 43.17 mins
Image differences available at: http://54.193.163.58:8877/d44e32abd833363/reftest-analyzer.html#web=eq.log |
Thank you for simplifying this! |
This function has been modified a number of times over the years, and at this point it's small/simple enough that we can just inline the code instead.