-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary signal
parameter from removeEventListener
calls
#18094
Remove unnecessary signal
parameter from removeEventListener
calls
#18094
Conversation
This parameter is not necessary, as outlined in https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener#options
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/432e4c11522dd96/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/432e4c11522dd96/output.txt Total script time: 1.16 mins Published |
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/029711ecd96ab81/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3c46238891dad81/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3c46238891dad81/output.txt Total script time: 7.44 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/029711ecd96ab81/output.txt Total script time: 21.89 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This parameter is not necessary, as outlined in https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener#options