-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support charCodes larger than 32-bit in adjustMapping
(issue 18117)
#18119
Conversation
This also required changing the initial `charCodeToGlyphId`-data to an Object, which seems generally correct since it's consistent with existing code in the `src\core\{cff_font, type1_font}.js` files.
3c78956
to
440b4b6
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7ee46a43b87b87c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/705522c7c66a0b6/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't expect it'd be so simple :)
LGTM.
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7ee46a43b87b87c/output.txt Total script time: 27.61 mins
Image differences available at: http://54.241.84.105:8877/7ee46a43b87b87c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/705522c7c66a0b6/output.txt Total script time: 42.70 mins
Image differences available at: http://54.193.163.58:8877/705522c7c66a0b6/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9b7200a6ea38499/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ea39fc3753615ca/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ea39fc3753615ca/output.txt Total script time: 20.01 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9b7200a6ea38499/output.txt Total script time: 25.41 mins
|
This also required changing the initial
charCodeToGlyphId
-data to an Object, which seems generally correct since it's consistent with existing code in thesrc\core\{cff_font, type1_font}.js
files.