Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor][Editor] When switching to editing mode, redraw pages containing editable annotations (bug 1883884) #18134

Merged
merged 1 commit into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. [api-minor][Editor] When switching to editing mode, redraw pages cont…

    …aining editable annotations
    
    Right now, editable annotations are using their own canvas when they're drawn, but
    it induces several issues:
     - if the annotation has to be composed with the page then the canvas must be correctly
       composed with its parent. That means we should move the canvas under canvasWrapper
       and we should extract composing info from the drawing instructions...
       Currently it's the case with highlight annotations.
     - we use some extra memory for those canvas even if the user will never edit them, which
       the case for example when opening a pdf in Fenix.
    
    So with this patch, all the editable annotations are drawn on the canvas. When the
    user switches to editing mode, then the pages with some editable annotations are redrawn but
    without them: they'll be replaced by their counterpart in the annotation editor layer.
    calixteman committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    64635f3 View commit details
    Browse the repository at this point in the history