Shorten the code in the web/text_layer_builder.js file
#18152
Conversation
- Use `this` rather than explicitly spelling out the class-name in the static `#enableGlobalSelectionListener` method, since that leads to shorter code. Given that all the relevant static fields are *private* ESLint will catch any scope errors in the code. - Reduce a little bit of duplication when using the `#selectionChangeAbortController` signal. - Utilize early returns in the "selectionchange" event handler, since that reduces overall indentation which helps readability a tiny bit.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a191dc982f3085/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/105c40f1452217f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3a191dc982f3085/output.txt Total script time: 7.47 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/105c40f1452217f/output.txt Total script time: 18.45 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/629ea1f855ca782/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/629ea1f855ca782/output.txt Total script time: 1.17 mins Published |
|
Thanks! |
Use
thisrather than explicitly spelling out the class-name in the static#enableGlobalSelectionListenermethod, since that leads to shorter code. Given that all the relevant static fields are private ESLint will catch any scope errors in the code.Reduce a little bit of duplication when using the
#selectionChangeAbortControllersignal.Utilize early returns in the "selectionchange" event handler, since that reduces overall indentation which helps readability a tiny bit.