-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the DownloadManager.downloadUrl
method
#18236
Conversation
This method has only a single call-site in the viewer, since it's used as a fallback, and the functionality can be moved into the `DownloadManager.download` method instead.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/09f030cce9c983a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2721d88557f7f02/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/09f030cce9c983a/output.txt Total script time: 7.66 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/2721d88557f7f02/output.txt Total script time: 22.66 mins
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bc4e600d8014282/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/bc4e600d8014282/output.txt Total script time: 1.09 mins Published |
Thank you for simplifying this! |
This method has only a single call-site in the viewer, since it's used as a fallback, and the functionality can be moved into the
DownloadManager.download
method instead.