Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an query with an empty selector in integration tests #18246

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

calixteman
Copy link
Contributor

In looking the logs from Chrome bidi tests I noticed a js syntax error which is fixed thanks to this patch.

In looking the logs from Chrome bidi tests I noticed a js syntax error
which is fixed thanks to this patch.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8ebeda90e654946/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/070a9d873c05835/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/8ebeda90e654946/output.txt

Total script time: 7.64 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/070a9d873c05835/output.txt

Total script time: 18.33 mins

  • Integration Tests: FAILED

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

For completeness, this fixes the following kind of log lines from http://54.193.163.58:8877/17884ed7bb0203f/output.txt:

JavaScript error: pptr:evaluateHandle;pasteFromClipboard%20(file%3A%2F%2F%2FC%3A%2Fpdfjs%2Fbotio-files-pdfjs%2Fprivate%2F17884ed7bb0203f%2Ftest%2Fintegration%2Ftest_utils.mjs%3A268%3A31), line 18: SyntaxError: Document.querySelector: '' is not a valid selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants