Fix an query with an empty selector in integration tests #18246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In looking the logs from Chrome bidi tests I noticed a js syntax error which is fixed thanks to this patch.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8ebeda90e654946/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/070a9d873c05835/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8ebeda90e654946/output.txt Total script time: 7.64 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/070a9d873c05835/output.txt Total script time: 18.33 mins
|
timvandermeij
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Nice find!
For completeness, this fixes the following kind of log lines from http://54.193.163.58:8877/17884ed7bb0203f/output.txt:
JavaScript error: pptr:evaluateHandle;pasteFromClipboard%20(file%3A%2F%2F%2FC%3A%2Fpdfjs%2Fbotio-files-pdfjs%2Fprivate%2F17884ed7bb0203f%2Ftest%2Fintegration%2Ftest_utils.mjs%3A268%3A31), line 18: SyntaxError: Document.querySelector: '' is not a valid selector
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking the logs from Chrome bidi tests I noticed a js syntax error which is fixed thanks to this patch.