Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute correctly the unitsPerEm value from the fontMatrix when converting a font (bug 1539074) #18253

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Compute correctly the unitsPerEm value from the fontMatrix when converting a font (bug 1539074) #18253

merged 1 commit into from
Jun 16, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6c33b73fec312ab/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a7b4a4a863d9e90/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6c33b73fec312ab/output.txt

Total script time: 28.59 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/6c33b73fec312ab/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a7b4a4a863d9e90/output.txt

Total script time: 43.71 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/a7b4a4a863d9e90/reftest-analyzer.html#web=eq.log

@calixteman calixteman requested a review from Snuffleupagus June 15, 2024 16:54
Snuffleupagus
Snuffleupagus approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman calixteman merged commit f8acd33 into mozilla:master Jun 16, 2024
9 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c11e1f7b1066b1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e95da285f99e90d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9c11e1f7b1066b1/output.txt

Total script time: 19.89 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/e95da285f99e90d/output.txt

Total script time: 24.33 mins

  • Make references: Passed
  • Check references: Passed

calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 24, 2024
@calixteman
Fix the computation of unitsPerEm when the fontMatrix has some negati…
a29a5b0 
…ve coefficients

It's a follow-up of mozilla#18253.
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 24, 2024
@calixteman
Fix the computation of unitsPerEm when the fontMatrix has some negati…
42bb2b0 
…ve coefficients

It's a follow-up of mozilla#18253.
@calixteman calixteman mentioned this pull request Jun 24, 2024
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus