Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Remove the various listeners when destroying the editor manager #18284

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[Editor] Remove the various listeners when destroying the editor manager #18284

merged 1 commit into from
Jun 19, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d7f0085ef166934/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ad44a079e71b15c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d7f0085ef166934/output.txt

Total script time: 7.66 mins

  • Integration Tests: Passed

@timvandermeij timvandermeij mentioned this pull request Jun 18, 2024
Open
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ad44a079e71b15c/output.txt

Total script time: 18.03 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the editor_signal branch 2 times, most recently from 36eec8d to ac26288 Compare June 18, 2024 19:49
@Snuffleupagus
Copy link
Collaborator

Maybe also change

pdf.js/src/display/editor/ink.js

Line 264 in 4b5d5a5

this.#observer.disconnect();
to this.#observer?.disconnect(); to avoid any future issue with ordering?

@calixteman calixteman requested a review from Snuffleupagus June 19, 2024 07:50
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1484e930beccdaf/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/658d976e3eb3373/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1484e930beccdaf/output.txt

Total script time: 7.63 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/658d976e3eb3373/output.txt

Total script time: 18.00 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

src/display/editor/tools.js Outdated Show resolved Hide resolved
src/display/editor/tools.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f9ff688456dfe84/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9a977f5460c5b74/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f9ff688456dfe84/output.txt

Total script time: 7.70 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9a977f5460c5b74/output.txt

Total script time: 18.49 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit c53f71a into mozilla:master Jun 19, 2024
9 checks passed
@calixteman calixteman deleted the editor_signal branch June 19, 2024 10:36
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus