-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Remove the various listeners when destroying the editor manager #18284
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d7f0085ef166934/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ad44a079e71b15c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d7f0085ef166934/output.txt Total script time: 7.66 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ad44a079e71b15c/output.txt Total script time: 18.03 mins
|
36eec8d
to
ac26288
Compare
ac26288
to
02dc809
Compare
Maybe also change pdf.js/src/display/editor/ink.js Line 264 in 4b5d5a5
this.#observer?.disconnect(); to avoid any future issue with ordering?
|
02dc809
to
7c6a790
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1484e930beccdaf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/658d976e3eb3373/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1484e930beccdaf/output.txt Total script time: 7.63 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/658d976e3eb3373/output.txt Total script time: 18.00 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
7c6a790
to
390afcb
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f9ff688456dfe84/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9a977f5460c5b74/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f9ff688456dfe84/output.txt Total script time: 7.70 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/9a977f5460c5b74/output.txt Total script time: 18.49 mins
|
No description provided.