Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw if there's not enough data to get the header in FlateStream (issue 18298) #18304

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Don't throw if there's not enough data to get the header in FlateStream (issue 18298) #18304

merged 1 commit into from
Jun 20, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Following in the footsteps of PR #17340.

@Snuffleupagus
Don't throw if there's not enough data to get the header in `FlateStr…
3fae2d7 
…eam` (issue 18298)

Following in the footsteps of PR 17340.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bd43552bea5877d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e23fe91cb6b511c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e23fe91cb6b511c/output.txt

Total script time: 28.77 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/e23fe91cb6b511c/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus linked an issue Jun 20, 2024 that may be closed by this pull request
PDF Text is rendered as transparent #18298
Closed
calixteman
calixteman approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bd43552bea5877d/output.txt

Total script time: 44.20 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/bd43552bea5877d/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit e76242d into mozilla:master Jun 20, 2024
9 checks passed
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/e97cfe77f9401a4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/82d2a0966dfe070/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e97cfe77f9401a4/output.txt

Total script time: 20.02 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/82d2a0966dfe070/output.txt

Total script time: 24.83 mins

  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-18298 branch June 20, 2024 12:41
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF Text is rendered as transparent
3 participants
@Snuffleupagus @moz-tools-bot @calixteman