Disable system addon updates for Firefox in testing mode #18316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the following log line that currently shows up for every type of tests that involve a browser: `System addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL.` If Firefox is in testing mode, the system addons update URL is configured to a dummy URL so that it can't actually update (see for example the same value in Marionette at https://searchfox.org/mozilla-central/source/testing/marionette/client/marionette_driver/geckoinstance.py#109), but this doesn't stop Firefox from trying to update, and when it does it logs this line because the URL is obviously invalid. Hence this patch which disables system addon updates altogether so Firefox doesn't attempt to use the dummy URL anymore. The browser updates are all managed by Puppeteer, and regular updates have already been disabled too (see https://github.com/puppeteer/puppeteer/blob/6937a76f0a442eca0c6381587b47298793798913/packages/browsers/src/browser-data/firefox.ts#L302-L303).
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f8e7647ad561c37/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4d010232a22625e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4d010232a22625e/output.txt Total script time: 8.27 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f8e7647ad561c37/output.txt Total script time: 19.37 mins
|
|
@timvandermeij thanks for the hint! I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1904310. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following log line that currently shows up for every type of tests that involve a browser:
System addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL.If Firefox is in testing mode, the system addons update URL is configured to a dummy URL so that it can't actually update (see for example the same value in Marionette at
https://searchfox.org/mozilla-central/source/testing/marionette/client/marionette_driver/geckoinstance.py#109), but this doesn't stop Firefox from trying to update, and when it does it logs this line because the URL is obviously invalid.
Hence this patch which disables system addon updates altogether so Firefox doesn't attempt to use the dummy URL anymore. The browser updates are all managed by Puppeteer, and regular updates have already been disabled too (see
https://github.com/puppeteer/puppeteer/blob/6937a76f0a442eca0c6381587b47298793798913/packages/browsers/src/browser-data/firefox.ts#L302-L303).
/cc @whimboo in case it's deemed useful to upstream this to Puppeteer/Marionette because it doesn't appear to be set there while it might be useful to do so.