Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the requestAnimationFrame work-around in L10n.prototype.destroy (PR 18313 follow-up) #18333

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Remove the requestAnimationFrame work-around in L10n.prototype.destroy (PR 18313 follow-up) #18333

merged 1 commit into from
Jun 25, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

With @fluent/dom 0.10.0 just published this work-around is no longer necessary.

@Snuffleupagus
Remove the requestAnimationFrame work-around in `L10n.prototype.des…
f676ce5 
…troy` (PR 18313 follow-up)

With `@fluent/dom 0.10.0` just published this work-around is no longer necessary.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/15f5d80fc1f22e4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/53c6bc293519c60/output.txt

calixteman
calixteman approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/53c6bc293519c60/output.txt

Total script time: 7.85 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/15f5d80fc1f22e4/output.txt

Total script time: 18.96 mins

  • Integration Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a27898a8bdc466c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a6d138a9befbf72/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a27898a8bdc466c/output.txt

Total script time: 8.32 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a6d138a9befbf72/output.txt

Total script time: 19.25 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too; thank you for improving this so we can get rid of the workaround!

@timvandermeij timvandermeij mentioned this pull request Jun 25, 2024
Open
@Snuffleupagus Snuffleupagus merged commit 7f58618 into mozilla:master Jun 25, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the l10n-destroy-rm-requestAnimationFrame branch June 25, 2024 16:34
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
dependencies test viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @calixteman