Attempt to improve support for using the PDF.js builds with Vite #18395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to Webpack there's apparently other bundlers that will not leave `import`-calls alone unless magic comments are used. Hence we extend the builder to also append `/* @vite-ignore */` comments to `import`-calls, in order to attempt to improve support for using the PDF.js builds together with Vite. This patch also renames `__non_webpack_import__` to `__raw_import__` since the functionality is no longer bundle-specific.
kevlened
reviewed
Jul 18, 2024
|
Closing for now, since no one seem to actually need or want this. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Can we revisit this? Many libraries depend on this one and for vite users, this is needed. |
@Foxandxss Please read all of #18395 (comment), from which I'm quoting:
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Webpack there's apparently other bundlers that will not leave
import-calls alone unless magic comments are used. Hence we extend the builder to also append/* @vite-ignore */comments toimport-calls, in order to attempt to improve support for using the PDF.js builds together with Vite.This patch also renames
__non_webpack_import__to__raw_import__since the functionality is no longer bundle-specific.Fixes #17245 (comment)
Please note: This will further increase the maintenance/support burden of the general PDF.js library, for a feature that's completely unused within the project itself.
Hence, if you'd like to see this patch landed, please contact me privately to discuss sponsoring this work (email address can be found in my GitHub profile).