Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change the toolbar height when changing the pref toolbar.density in Firefox (bug 1171799) #18397

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

calixteman
Copy link
Contributor

It's a first step to just dispatch the pref change to the toolbar. The second one, to effectively use it, will come after PR #18385 is merged.

@calixteman
Copy link
Contributor Author

This patch is linked to:
https://phabricator.services.mozilla.com/D215840

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed; thank you!

web/app.js Outdated Show resolved Hide resolved
web/preferences.js Outdated Show resolved Hide resolved
web/app_options.js Outdated Show resolved Hide resolved
…sity in Firefox (bug 1171799)

It's a first step to just dispatch the pref change to the toolbar.
The second one, to effectively use it, will come after PR mozilla#18385 is merged.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5f4c377dce34650/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/8891dbe9fe88686/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8891dbe9fe88686/output.txt

Total script time: 7.94 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/5f4c377dce34650/output.txt

Total script time: 16.96 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 9f00105 into mozilla:master Jul 5, 2024
7 checks passed
@calixteman calixteman deleted the toolbar_density branch July 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants