Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orphaned browser processes due to uncaught exceptions in the tests #18401

Merged
merged 1 commit into from
Jul 6, 2024

Commits on Jul 6, 2024

  1. Fix orphaned browser processes due to uncaught exceptions in the tests

    If uncaught exceptions occur in the tests (which happened in mozilla#17962 and
    can be triggered manually by throwing an error in `integration-boot.js`)
    the teardown logic of the tests doesn't get to run and thus spawned
    browser processes are not closed properly. Given that `test.mjs` is the
    only process that has a reference to them they will become orphaned and
    keep running if `test.mjs` exits without explicitly closing them.
    
    This commit fixes the issue by always closing the browsers if uncaught
    exceptions occur, and we make sure to log them for debugging purposes.
    timvandermeij committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3afe2d3 View commit details
    Browse the repository at this point in the history