-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow e.g. /FitH destinations without additional parameter (bug 1907000) #18421
Conversation
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/593c7cf83ce928c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/35dabff66354061/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/593c7cf83ce928c/output.txt Total script time: 2.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/35dabff66354061/output.txt Total script time: 6.67 mins
|
Here's a basic test file: |
According to the PDF specification these destinations should have a coordinate parameter, which may however be `null`, but it shouldn't be omitted; please see https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2095870 Hence we try to work-around bad PDF generators by making the coordinate parameter optional when validating explicit destinations in both the worker and the viewer.
ddcf1e2
to
403d023
Compare
Thank you! /botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/572dd2ae66c5586/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/90ac0b598b7863a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/572dd2ae66c5586/output.txt Total script time: 2.51 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/90ac0b598b7863a/output.txt Total script time: 6.43 mins
|
According to the PDF specification these destinations should have a coordinate parameter, which may however be
null
, but it shouldn't be omitted; please see https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2095870Hence we try to work-around bad PDF generators by making the coordinate parameter optional when validating explicit destinations in both the worker and the viewer.