-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow /XYZ destinations without zoom parameter (issue 18408) #18453
Conversation
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d1ecce37c8d43e2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/80d1cebf235a780/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/80d1cebf235a780/output.txt Total script time: 29.94 mins
Image differences available at: http://54.241.84.105:8877/80d1cebf235a780/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
According to the PDF specification these destinations should have a zoom parameter, which may however be `null`, but it shouldn't be omitted; please see https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2095870 Hence we try to work-around bad PDF generators by making the zoom parameter optional when validating explicit destinations in both the worker and the viewer.
f2ecc90
to
d24a61c
Compare
Updated to fix a copy-paste error in the commit message, no code changes were made. |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d1ecce37c8d43e2/output.txt Total script time: 44.52 mins
Image differences available at: http://54.193.163.58:8877/d1ecce37c8d43e2/reftest-analyzer.html#web=eq.log |
According to the PDF specification these destinations should have a zoom parameter, which may however be
null
, but it shouldn't be omitted; please see https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G11.2095870Hence we try to work-around bad PDF generators by making the zoom parameter optional when validating explicit destinations in both the worker and the viewer.