Disable system fonts on Android (issue 18210) #18465
Conversation
Snuffleupagus
force-pushed
the
issue-18210
branch
3 times, most recently
from
7de8c7c
to
9cc7616
Compare
|
/botio integrationtest |
Snuffleupagus
force-pushed
the
issue-18210
branch
from
9cc7616
to
f0f486b
Compare
Snuffleupagus
force-pushed
the
issue-18210
branch
from
f0f486b
to
1aed680
Compare
Snuffleupagus
force-pushed
the
issue-18210
branch
2 times, most recently
from
b03b027
to
583806e
Compare
Snuffleupagus
force-pushed
the
issue-18210
branch
from
583806e
to
03b9a80
Compare
Besides being slightly shorter, this should help reduce the risk of confusion given the very similar global Object/Map names.
To avoid introducing any inline "hacks" in the viewer-code this meant adding `useSystemFonts` to the AppOptions, which thus required some new functionality since the default value should be `undefined` given how the option is handled in the API; note [this code](https://github.com/mozilla/pdf.js/blob/ed83d7c5e16798a56c493d56aaa8200dd280bb17/src/display/api.js#L298-L301). Finally, also moves the definition of the development-mode `window.isGECKOVIEW` property to the HTML file such that it's guaranteed to be set regardless of how and when it's accessed.
Snuffleupagus
force-pushed
the
issue-18210
branch
from
03b9a80
to
80d6bf6
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b43cebdb0c5fc1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5202ef0e8697165/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9b43cebdb0c5fc1/output.txt Total script time: 2.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5202ef0e8697165/output.txt Total script time: 7.63 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9592c2f1e9c812b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/758af2cad22909b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9592c2f1e9c812b/output.txt Total script time: 8.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/758af2cad22909b/output.txt Total script time: 19.40 mins
|
|
Thank you for fixing this! |
To avoid introducing any inline "hacks" in the viewer-code this meant adding
useSystemFontsto the AppOptions, which thus required some new functionality since the default value should beundefinedgiven how the option is handled in the API; note this code.Finally, also moves the definition of the development-mode
window.isGECKOVIEWproperty to the HTML file such that it's guaranteed to be set regardless of how and when it's accessed.