Use a transparent color when setting fill/stroke colors in a pattern context but with no colorspace #18467
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/319e40c5a30bbe1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/23fcad13e2f64a4/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/23fcad13e2f64a4/output.txt Total script time: 30.17 mins
Image differences available at: http://54.241.84.105:8877/23fcad13e2f64a4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/319e40c5a30bbe1/output.txt Total script time: 44.40 mins
Image differences available at: http://54.193.163.58:8877/319e40c5a30bbe1/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9553bf4eebc57ff/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0ea6a48f5076615/output.txt |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/7019f4fa170a184/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/16758c66f66ce97/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9553bf4eebc57ff/output.txt Total script time: 30.24 mins
Image differences available at: http://54.241.84.105:8877/9553bf4eebc57ff/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0ea6a48f5076615/output.txt Total script time: 44.89 mins
Image differences available at: http://54.193.163.58:8877/0ea6a48f5076615/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7019f4fa170a184/output.txt Total script time: 30.06 mins
Image differences available at: http://54.241.84.105:8877/7019f4fa170a184/reftest-analyzer.html#web=eq.log |
|
There is a regression in issue6707.pdf. diff --git a/src/core/colorspace.js b/src/core/colorspace.js
index 74b43a1c4..ee2e8493c 100644
--- a/src/core/colorspace.js
+++ b/src/core/colorspace.js
@@ -396,7 +396,8 @@ class ColorSpace {
}
}
}
- throw new FormatError(`Unrecognized ColorSpace: ${cs.name}`);
+ return this.singletons.gray;
+ //throw new FormatError(`Unrecognized ColorSpace: ${cs.name}`);
}
}
if (Array.isArray(cs)) {and interestingly the above pdf shows stuff which was invisible before. |
Without testing I really don't know what the general effect would be if we change all the relevant cases in that method to just "swallow" errors, since it might "fix" some things and break others. Maybe we should just update this patch to address the referenced issue, without regressing anything, and then we could look into those ideas in a follow-up instead to reduce the number of "moving parts" in this PR? |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/16758c66f66ce97/output.txt Total script time: 45.02 mins
Image differences available at: http://54.193.163.58:8877/16758c66f66ce97/reftest-analyzer.html#web=eq.log |
…context but with no colorspace
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/edb8b6eae34032f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a5321997a773d60/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a5321997a773d60/output.txt Total script time: 29.91 mins
Image differences available at: http://54.241.84.105:8877/a5321997a773d60/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/edb8b6eae34032f/output.txt Total script time: 44.63 mins
Image differences available at: http://54.193.163.58:8877/edb8b6eae34032f/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9b69194e2ae546e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f5cb9798e6c176b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9b69194e2ae546e/output.txt Total script time: 20.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f5cb9798e6c176b/output.txt Total script time: 25.01 mins
|
No description provided.