-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to the most recent versions #18506
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/534334017ebeddc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/534334017ebeddc/output.txt Total script time: 1.03 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1138da8af1e6b96/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e923dd06355bd76/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1138da8af1e6b96/output.txt Total script time: 21.58 mins
Image differences available at: http://54.241.84.105:8877/1138da8af1e6b96/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e923dd06355bd76/output.txt Total script time: 45.78 mins
Image differences available at: http://54.193.163.58:8877/e923dd06355bd76/reftest-analyzer.html#web=eq.log |
I'm not sure yet what's up with the Linux bot, but I'm pretty sure it can't be caused by the changes here. I deliberately left out Puppeteer and the other ones here should not cause this. We did notice with the earlier versions of this patch that lots of Chrome processes were running on the Linux bot, so the OOM issue is probably caused by browser processes being left behind by previous runs, but it's unclear why that would happen... |
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b6ef1fd7ea269ac/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b6ef1fd7ea269ac/output.txt Total script time: 20.49 mins
Image differences available at: http://54.241.84.105:8877/b6ef1fd7ea269ac/reftest-analyzer.html#web=eq.log |
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1ffbad6de29ea16/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1ffbad6de29ea16/output.txt Total script time: 20.21 mins
Image differences available at: http://54.241.84.105:8877/1ffbad6de29ea16/reftest-analyzer.html#web=eq.log |
/botio-linux browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e42c30254216bc2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e42c30254216bc2/output.txt Total script time: 20.41 mins
Image differences available at: http://54.241.84.105:8877/e42c30254216bc2/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/42818297e9fb5ed/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/08a1619a072581d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/42818297e9fb5ed/output.txt Total script time: 29.77 mins
Image differences available at: http://54.241.84.105:8877/42818297e9fb5ed/reftest-analyzer.html#web=eq.log |
This is a major version bump, but the changelog at https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v55.0.0 doesn't indicate any breaking changes that should impact us.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/08a1619a072581d/output.txt Total script time: 44.84 mins
Image differences available at: http://54.193.163.58:8877/08a1619a072581d/reftest-analyzer.html#web=eq.log |
This should avoid the timeouts and OOM issues we have on the Linux bot, which started since PR mozilla#18473.
eslint-plugin-unicorn
to version 55.0.0
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/596a49452edfa96/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e0dea6d777526a3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/596a49452edfa96/output.txt Total script time: 29.93 mins
Image differences available at: http://54.241.84.105:8877/596a49452edfa96/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e0dea6d777526a3/output.txt Total script time: 44.41 mins
Image differences available at: http://54.193.163.58:8877/e0dea6d777526a3/reftest-analyzer.html#web=eq.log |
This should be ready now that disabling WebDriver BiDi for Chrome seems to have fixed the timeout and OOM issues. Note that using WebDriver BiDi for Firefox and CDP for Chrome also matches the upcoming default behavior in Puppeteer 23; see puppeteer/puppeteer#12728 and https://github.com/puppeteer/puppeteer/pull/12732/files#diff-8b40d1cbf56e2b8f3e21919bcd5f815060634e9b604a5f026f452633ac2e2f3bR96. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
The commit messages contain more details about the individual changes. No translation updates are available upstream this time.