Commits on Jul 29, 2024

1. Improve how the findbar's toggle button is referenced in the viewer code …

   The sidebar and secondary toolbar both have a reference to their toggle
   buttons in their own sections in `getViewerConfiguration`, so it makes
   sense for the findbar to do the same.
   
   While we actually have a findbar-specific reference to the toggle
   button, I noticed that we don't use it consistently because the toolbar
   also has a reference to the exact same toggle button and we use both in
   the code. This is probably for historical reasons: the docstring in the
   toolbar file indicates that the `viewFind` element is an input to the
   component, but that option is never actually used in the code itself.
   
   This commit fixes the issue by removing the toolbar-specific reference,
   since it's not actually used (anymore) in the toolbar code, so that we
   consistently use the findbar-specific reference everywhere.

   

   timvandermeij committed Jul 29, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f430a6b
   • Browse repository at this point

   Copy the full SHA

   f430a6b View commit details

   Browse the repository at this point in the history