-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Add a first test to test the new alt text flow #18581
Conversation
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2011a9693f32adc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/365ec3debbcd110/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/365ec3debbcd110/output.txt Total script time: 8.52 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2011a9693f32adc/output.txt Total script time: 18.95 mins
|
fd2a320
to
0864aef
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dfe77c355ba6018/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4f396bdfd48f6ec/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4f396bdfd48f6ec/output.txt Total script time: 8.55 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dfe77c355ba6018/output.txt Total script time: 21.01 mins
|
Good to see test coverage for the new flow! I'll review this either tomorrow or during the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with a few smaller comments.
2988492
to
51e83f2
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/01bfc93b44fbf1e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7851f54e6892d44/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/01bfc93b44fbf1e/output.txt Total script time: 11.61 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7851f54e6892d44/output.txt Total script time: 20.85 mins
|
51e83f2
to
debcb22
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/19daa0bf8f94913/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d3b8d817cef054d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/19daa0bf8f94913/output.txt Total script time: 8.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/d3b8d817cef054d/output.txt Total script time: 18.30 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with a follow-up for the "Create automatically" toggle test, and preferably one to find out why always waiting for the input even in clearInput
causes test failures since AFAICT that should have been safe (but the current solution is good now). Thank you for implementing test coverage for this flow!
No description provided.