Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group and scope the secondary toolbar button container/icon rules using CSS nesting #18595

Merged

Commits on Aug 11, 2024

  1. Group and scope the secondary toolbar button container/icon rules usi…

    …ng CSS nesting
    
    The secondary toolbar CSS rules predate the general availability of CSS
    nesting, which makes them more difficult to understand and change
    safely. The primary issues are that the rules are spread over the
    `viewer.css` file, they share blocks with other elements and the scope
    of the rules is sometimes bigger than necessary.
    
    This refactoring groups all CSS rules for the secondary toolbar button
    container/icons together, scoped to the top-level `#secondaryToolbar`
    element, for improved overview and isolation. Note that this patch only
    intends to move the existing rules around and not change any behavior.
    Moreover, this patch does not move the rules for the secondary toolbar
    itself and the secondary toolbar buttons; those will be part of a
    follow-up patch and will be easier once this is in place first.
    
    Co-authored-by: Calixte Denizet <calixte.denizet@gmail.com>
    timvandermeij and calixteman committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    97b761d View commit details
    Browse the repository at this point in the history