Commits on Aug 18, 2024

1. Fix the "must check that a value is correctly updated on a field and … …

   …its siblings" scripting integration test
   
   This integration test fails intermittently because we cache the initial
   total value to be able to compare it to the new total value at the end
   of the test to check that it's different before doing the assertions.
   However, this doesn't work as expected because the second `clearInput`
   call triggers an intermediate total value calculation because it clicks
   on another input field and that triggers a sandbox event.
   
   This results in the `waitForFunction` calls always resolving immediately
   and since we don't use other means of waiting until the calculation is
   done (using e.g. `waitForSandboxTrip`) we basically rely on the time
   between the final click and the assertions to be enough for the sandbox
   to do its work. If it's is not done in that time, we do the assertions
   with older values and that makes the test fail.
   
   This commit fixes the issue by simply waiting for the total value to be
   what we expect it to be. This requires less code, is more consistent
   with the other integration tests and removes the possibility of doing
   assertions against older values.

   

   timvandermeij committed Aug 18, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 5cc77d3
   • Browse repository at this point

   Copy the full SHA

   5cc77d3 View commit details

   Browse the repository at this point in the history